What code smells did you spot in this code sample?

Duplicated code 13% (156 votes)
Long method 13% (148 votes)
Long parameter list 4% (49 votes)
Uncommunicative name 6% (75 votes)
Inconsistent names 7% (79 votes)
Inappropriate intimacy 4% (51 votes)
Indecent exposure 3% (34 votes)
Large Classes 5% (63 votes)
Classes with too little code 7% (76 votes)
Divergent change 3% (33 votes)
A large number of function classes 3% (34 votes)
Feature envy 4% (47 votes)
Data clumps 4% (50 votes)
Switch statements 2% (22 votes)
Speculative generality 3% (33 votes)
Too many casts 4% (43 votes)
Comments 7% (76 votes)
Did not implement hashcode() 3% (39 votes)
Poor API design 5% (55 votes)
Other <1% 4 votes

Total Votes: 1,167

See this poll on: https://poll.fm/717541/embed

1 Comment

Vivek Agarwal - 16 years ago

Visit http://vivekagarwal.wordpress.com/2008/06/21/code-smelling-exercise/ to view the code sample that this poll references.

Leave a Comment

Create your own.

Opinions! We all have them. Find out what people really think with polls and surveys from Crowdsignal.